frankvicky commented on code in PR #17168:
URL: https://github.com/apache/kafka/pull/17168#discussion_r1759089186
##########
core/src/test/java/kafka/admin/ConfigCommandIntegrationTest.java:
##########
@@ -528,6 +529,17 @@ public void
testUpdatePerBrokerConfigInKRaftThenShouldFail() {
}
}
+ @ClusterTest(types = {Type.CO_KRAFT, Type.KRAFT})
+ public void testIntervalMsParser() {
+ alterOpts = asList("--bootstrap-server", cluster.bootstrapServers(),
+ "--alter", "--entity-type", "client-metrics", "--entity-name",
"test");
+ try (Admin client = cluster.createAdminClient()) {
+ Throwable e = assertThrows(ExecutionException.class, () ->
+ alterConfigWithKraft(client, Optional.of(defaultBrokerId),
singletonMap("interval.ms", "aaa")));
+
Assertions.assertTrue(e.getMessage().contains("InvalidConfigurationException"));
Review Comment:
There is a static import `import static
org.junit.jupiter.api.Assertions.assertTrue`, so `Assertions` could be omitted.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
