smjn commented on code in PR #17149:
URL: https://github.com/apache/kafka/pull/17149#discussion_r1757017297
##########
checkstyle/suppressions.xml:
##########
@@ -340,6 +340,14 @@
<suppress checks="NPathComplexity"
files="CoordinatorRuntime.java"/>
+ <!-- share coordinator -->
+ <suppress checks="MethodLength"
+ files="ShareCoordinatorShardTest.java"/>
+ <suppress checks="NPathComplexity"
+ files="ShareCoordinatorShard.java"/>
+ <suppress checks="CyclomaticComplexity"
+ files="ShareCoordinatorShard.java"/>
Review Comment:
The problem will still remain, since the test cases are curated to create
various scenarios. We cannot generate them deterministically. If I add a new
private method to return the tests, it will still five MethodLength issue.
Best I can do is to suppress warning for this specific method.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
