mjsax commented on code in PR #17170:
URL: https://github.com/apache/kafka/pull/17170#discussion_r1755871404
##########
streams/src/test/java/org/apache/kafka/streams/StreamsConfigTest.java:
##########
@@ -600,24 +562,7 @@ public void
shouldNotSetInternalAutoDowngradeTxnCommitToTrueInProducerForEosDisa
assertThat(producerConfigs.get("internal.auto.downgrade.txn.commit"),
is(nullValue()));
}
- @SuppressWarnings("deprecation")
- @Test
- public void
shouldSetInternalAutoDowngradeTxnCommitToTrueInProducerForEosAlpha() {
- props.put(StreamsConfig.PROCESSING_GUARANTEE_CONFIG, EXACTLY_ONCE);
- final StreamsConfig streamsConfig = new StreamsConfig(props);
- final Map<String, Object> producerConfigs =
streamsConfig.getProducerConfigs(clientId);
- assertThat(producerConfigs.get("internal.auto.downgrade.txn.commit"),
is(true));
- }
-
- @SuppressWarnings("deprecation")
- @Test
- public void
shouldNotSetInternalAutoDowngradeTxnCommitToTrueInProducerForEosBeta() {
- props.put(StreamsConfig.PROCESSING_GUARANTEE_CONFIG,
EXACTLY_ONCE_BETA);
- final StreamsConfig streamsConfig = new StreamsConfig(props);
- final Map<String, Object> producerConfigs =
streamsConfig.getProducerConfigs(clientId);
- assertThat(producerConfigs.get("internal.auto.downgrade.txn.commit"),
is(nullValue()));
- }
-
+ // TODO: should we keep this test? (cf other TODO)
Review Comment:
Relates to the question above, about the remove code which sets the internal
config.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
