mjsax commented on code in PR #17110:
URL: https://github.com/apache/kafka/pull/17110#discussion_r1755856161
##########
streams/src/test/java/org/apache/kafka/streams/integration/EosIntegrationTest.java:
##########
@@ -176,13 +176,13 @@ public void createTopics() throws Exception {
}
@ParameterizedTest
- @ValueSource(strings = {StreamsConfig.AT_LEAST_ONCE,
StreamsConfig.EXACTLY_ONCE, StreamsConfig.EXACTLY_ONCE_V2})
+ @ValueSource(strings = {StreamsConfig.AT_LEAST_ONCE,
StreamsConfig.EXACTLY_ONCE_V2})
Review Comment:
Seems this is a mess -- the original PR actually also added "early returns"
for some test... Guess we need to do more follow up cleanup.
Seem one root cause if, that we have a centralized parameter originally, but
now a per-test one.
But should be its own PR to do this cleanup, after this one was merged.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
