mjsax commented on code in PR #17126:
URL: https://github.com/apache/kafka/pull/17126#discussion_r1755591842
##########
streams/src/test/java/org/apache/kafka/streams/integration/AbstractResetIntegrationTest.java:
##########
@@ -349,7 +348,7 @@ private Topology setupTopologyWithIntermediateTopic(final
boolean useRepartition
stream = builder.stream(INTERMEDIATE_USER_TOPIC);
}
stream.groupByKey()
- .windowedBy(TimeWindows.of(ofMillis(35)).advanceBy(ofMillis(10)))
+
.windowedBy(TimeWindows.ofSizeWithNoGrace(ofMillis(35)).advanceBy(ofMillis(10)))
Review Comment:
I am totally ok to remove grace period if we don't need it -- just want to
understand, why a test does not need it. Your explanation make total sense.
Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
