ShivsundarR commented on code in PR #17136:
URL: https://github.com/apache/kafka/pull/17136#discussion_r1754905117
##########
clients/src/main/java/org/apache/kafka/clients/consumer/internals/ShareConsumeRequestManager.java:
##########
@@ -84,10 +86,9 @@ public class ShareConsumeRequestManager implements
RequestManager, MemberStateLi
private Uuid memberId;
private boolean fetchMoreRecords = false;
private final Map<TopicIdPartition, Acknowledgements>
fetchAcknowledgementsMap;
- private final Map<Integer, Pair<AcknowledgeRequestState>>
acknowledgeRequestStates;
+ private final Map<Integer, Tuple<AcknowledgeRequestState>>
acknowledgeRequestStates;
private final long retryBackoffMs;
private final long retryBackoffMaxMs;
- private boolean closing = false;
private final CompletableFuture<Void> closeFuture;
Review Comment:
Yes, thanks, I had missed this. I am now put an extra variable to indicate
if a requestState has completed processing, and then accordingly waited till
all the nodes are finished and then completed the `closeFuture`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
