FrankYang0529 commented on code in PR #17075:
URL: https://github.com/apache/kafka/pull/17075#discussion_r1751803881
##########
clients/src/test/java/org/apache/kafka/clients/consumer/internals/events/ApplicationEventProcessorTest.java:
##########
@@ -183,6 +186,38 @@ public void testAssignmentChangeEventWithException() {
assertInstanceOf(IllegalStateException.class, e.getCause());
}
+ @ParameterizedTest
+ @ValueSource(booleans = {true, false})
Review Comment:
Yes, I think we don't need to test both situations for this case. Thanks.
##########
clients/src/main/java/org/apache/kafka/clients/consumer/internals/events/SeekUnvalidatedEvent.java:
##########
@@ -0,0 +1,56 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.kafka.clients.consumer.internals.events;
+
+import org.apache.kafka.clients.consumer.internals.SubscriptionState;
+import org.apache.kafka.common.TopicPartition;
+
+import java.util.Optional;
+
+/**
+ * Event to perform {@link
org.apache.kafka.clients.consumer.internals.SubscriptionState#seekUnvalidated(TopicPartition,
SubscriptionState.FetchPosition)}
+ * in the background thread. This can avoid race conditions when subscription
state is updated.
+ */
+public class SeekUnvalidatedEvent extends CompletableApplicationEvent<Void> {
+ private final TopicPartition partition;
+ private final long offset;
+ private final Optional<Integer> offsetEpoch;
+
+ public SeekUnvalidatedEvent(long deadlineMs, TopicPartition partition,
long offset, Optional<Integer> offsetEpoch) {
+ super(Type.SEEK_UNVALIDATED, deadlineMs);
+ this.partition = partition;
+ this.offset = offset;
+ this.offsetEpoch = offsetEpoch;
+ }
+
+ public TopicPartition partition() {
+ return partition;
+ }
+
+ public long offset() {
+ return offset;
+ }
+
+ public Optional<Integer> offsetEpoch() {
+ return offsetEpoch;
+ }
+
+ @Override
+ protected String toStringBase() {
+ return super.toStringBase() + ", partition=" + partition + ", offset="
+ offset + ", offsetEpoch=" + offsetEpoch;
Review Comment:
Thanks for the review. Updated it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
