dajac commented on code in PR #16898:
URL: https://github.com/apache/kafka/pull/16898#discussion_r1750755884
##########
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupMetadataManager.java:
##########
@@ -842,33 +838,40 @@ ConsumerGroup consumerGroup(
* created if it does not exist.
*
* @return A ConsumerGroup.
- * @throws IllegalStateException if the group does not exist and
createIfNotExists is false or
- * if the group is not a consumer group.
+ * @throws GroupIdNotFoundException if the group does not exist and
createIfNotExists is false or
+ * if the group is not a consumer group.
+ * @throws IllegalStateException if the group does not have the
expected type.
* Package private for testing.
*/
ConsumerGroup getOrMaybeCreatePersistedConsumerGroup(
String groupId,
boolean createIfNotExists
- ) throws GroupIdNotFoundException {
+ ) throws IllegalStateException {
Review Comment:
My bad. Both should be there.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
