gharris1727 commented on code in PR #17038:
URL: https://github.com/apache/kafka/pull/17038#discussion_r1745922035
##########
connect/mirror/src/main/java/org/apache/kafka/connect/mirror/MirrorCheckpointConnector.java:
##########
@@ -262,12 +264,13 @@ private void createInternalTopics() {
);
}
- Map<TopicPartition, OffsetAndMetadata> listConsumerGroupOffsets(String
group)
+ ListConsumerGroupOffsetsResult listConsumerGroupOffsets(List<String>
groups)
throws InterruptedException, ExecutionException {
+ Map<String, ListConsumerGroupOffsetsSpec> groupSpecs = groups.stream()
+ .collect(Collectors.toMap(group -> group, group -> new
ListConsumerGroupOffsetsSpec()));
return adminCall(
- () ->
sourceAdminClient.listConsumerGroupOffsets(group).partitionsToOffsetAndMetadata().get(),
- () -> String.format("list offsets for consumer group %s on %s
cluster", group,
- config.sourceClusterAlias())
+ () -> sourceAdminClient.listConsumerGroupOffsets(groupSpecs),
+ () -> String.format("list offsets for consumer groups %s on %s
cluster", groups, config.sourceClusterAlias())
);
Review Comment:
I think to make this adminCall functional, the first argument needs to be
blocking. I think you need to use .all().get() instead of returning the whole
Result object.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
