cmccabe commented on code in PR #17094:
URL: https://github.com/apache/kafka/pull/17094#discussion_r1744602613
##########
core/src/main/scala/kafka/server/KafkaServer.scala:
##########
@@ -418,7 +418,14 @@ class KafkaServer(
kafkaController.startup()
if (config.migrationEnabled) {
- logger.info("Starting up additional components for ZooKeeper
migration")
+ if
(config.interBrokerProtocolVersion.isMetadataTransactionSupported) {
+ logger.info("Starting up additional components for ZooKeeper
migration")
+ } else {
+ logger.error("Caution! Starting up additional components for
ZooKeeper migration without metadata transactions. " +
Review Comment:
Small nit. Can we do the preceding log, but have an additional log at ERROR
level saying that we don't support metadata transactions?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
