mjsax commented on code in PR #17005:
URL: https://github.com/apache/kafka/pull/17005#discussion_r1742819290
##########
docs/streams/developer-guide/config-streams.html:
##########
@@ -83,6 +83,7 @@
<li><a class="reference internal"
href="#probing-rebalance-interval-ms"
id="id30">probing.rebalance.interval.ms</a></li>
<li><a class="reference internal"
href="#processing-exception-handler"
id="id41">processing.exception.handler</a></li>
<li><a class="reference internal" href="#processing-guarantee"
id="id25">processing.guarantee</a></li>
+ <li><a class="reference internal"
href="#production-exception-handler"
id="id43">production.exception.handler</a></li>
Review Comment:
This is still adding a new link `<a ... href="#production-exception-handler"
...>` which is dangling...
I think we should update the HTML here to use `production-exception-handler`
as new anchor point:
https://kafka.apache.org/38/documentation/streams/developer-guide/config-streams.html#default-production-exception-handler
Ie, old and new should point to the same section which we update...
(including the headline):
```
- <div class="section" id="default-production-exception-handler">
+ <div class="section" id="production-exception-handler">
```
And
```
- <span id="streams-developer-guide-peh"></span><h4><a class="toc-backref"
href="#id24">default.production.exception.handler</a><a class="headerlink"
href="#default-production-exception-handler" title="Permalink to this
headline"></a></h4>
+ <span id="streams-developer-guide-peh"></span><h4><a class="toc-backref"
href="#id24">production.exception.handler (deprecated:
default.production.exception.handler)</a><a class="headerlink"
href="#default-production-exception-handler" title="Permalink to this
headline"></a></h4>
```
Same for the other config.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
