junrao commented on code in PR #16969:
URL: https://github.com/apache/kafka/pull/16969#discussion_r1739387577
##########
core/src/main/java/kafka/server/share/SharePartitionManager.java:
##########
@@ -498,10 +519,17 @@ List<TopicIdPartition>
cachedTopicIdPartitionsInShareSession(String groupId, Uui
return cachedTopicIdPartitions;
}
+ // Add the share fetch request to the delayed share fetch purgatory to
process the fetch request if it can be
+ // completed else watch until it can be completed/timeout.
+ private void addDelayedShareFetch(DelayedShareFetch delayedShareFetch,
Set<Object> keys) {
+
this.delayedShareFetchPurgatory.tryCompleteElseWatch(delayedShareFetch,
CollectionConverters.asScala(keys).toSeq());
Review Comment:
We want to be consistent with using the instance val. In other places, we
don't use `this`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
