dajac commented on code in PR #17057:
URL: https://github.com/apache/kafka/pull/17057#discussion_r1738523290
##########
core/src/main/scala/kafka/server/KafkaConfig.scala:
##########
@@ -576,19 +576,13 @@ class KafkaConfig private(doLog: Boolean, val props:
util.Map[_, _])
throw new ConfigException(s"Disabling the '${GroupType.CLASSIC}'
protocol is not supported.")
}
if (protocols.contains(GroupType.CONSUMER)) {
- if (processRoles.isEmpty) {
Review Comment:
I had to soften the validation here because ZK also has the new default
value now. Keep in mind that ZK will be remove entirely in 4.0 so it won't be
an issue for the next release.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
