[ 
https://issues.apache.org/jira/browse/KAFKA-7449?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16630513#comment-16630513
 ] 

ASF GitHub Bot commented on KAFKA-7449:
---------------------------------------

mchataigner opened a new pull request #5704: KAFKA-7449 Forward topic from 
console consumer to deserializer
URL: https://github.com/apache/kafka/pull/5704
 
 
   Some deserializer needs the topic name to be able to correctly deserialize 
the payload of the message.
   Console consumer works great with Deserializer<String> however it calls 
deserializer with topic set as null.
   This breaks the API and the topic information is available in the 
ConsumerRecord.
   
   *More detailed description of your change,
   if necessary. The PR title and PR message become
   the squashed commit message, so use a separate
   comment to ping reviewers.*
   
   *Summary of testing strategy (including rationale)
   for the feature or bug fix. Unit and/or integration
   tests are expected for any behaviour change and
   system tests should be considered for larger changes.*
   
   ### Committer Checklist (excluded from commit message)
   - [ ] Verify design and implementation 
   - [ ] Verify test coverage and CI build status
   - [ ] Verify documentation (including upgrade notes)
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


> Kafka console consumer is not sending topic to deserializer
> -----------------------------------------------------------
>
>                 Key: KAFKA-7449
>                 URL: https://issues.apache.org/jira/browse/KAFKA-7449
>             Project: Kafka
>          Issue Type: Bug
>          Components: core
>            Reporter: Mathieu Chataigner
>            Priority: Major
>
> We tried to create a custom Deserializer to consume some protobuf topics.
> We have a mechanism for getting the protobuf class from topic name however 
> the console consumer is not forwarding the topic of the console consumer 
> record down to the deserializer.
> Topic information is available in the ConsumerRecord.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to