mjsax commented on code in PR #16988:
URL: https://github.com/apache/kafka/pull/16988#discussion_r1735339211
##########
streams/src/main/java/org/apache/kafka/streams/KafkaStreams.java:
##########
@@ -418,32 +418,6 @@ public void setStateListener(final
KafkaStreams.StateListener listener) {
}
}
- /**
- * Set the handler invoked when an internal {@link
StreamsConfig#NUM_STREAM_THREADS_CONFIG stream thread} abruptly
- * terminates due to an uncaught exception.
- *
- * @param uncaughtExceptionHandler the uncaught exception handler for all
internal threads; {@code null} deletes the current handler
- * @throws IllegalStateException if this {@code KafkaStreams} instance has
already been started.
- *
- * @deprecated Since 2.8.0. Use {@link
KafkaStreams#setUncaughtExceptionHandler(StreamsUncaughtExceptionHandler)}
instead.
- *
- */
- @Deprecated
- public void setUncaughtExceptionHandler(final
Thread.UncaughtExceptionHandler uncaughtExceptionHandler) {
- synchronized (stateLock) {
- if (state.hasNotStarted()) {
- oldHandler = true;
Review Comment:
We should also remove `oldHandler` and cleanup all code that "bridges"
between old and new handler
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
