muralibasani commented on code in PR #17005:
URL: https://github.com/apache/kafka/pull/17005#discussion_r1732520717
##########
streams/src/test/java/org/apache/kafka/streams/processor/internals/InternalTopologyBuilderTest.java:
##########
@@ -1066,6 +1067,41 @@ public void
shouldOverrideGlobalStreamsConfigWhenGivenNamedTopologyProps() {
assertThat(topologyBuilder.topologyConfigs().parseStoreType(),
equalTo(Materialized.StoreType.IN_MEMORY));
}
+ @SuppressWarnings("deprecation")
+ @Test
+ public void exceptionHandlerShouldAcceptNewConfig() {
+ final Properties topologyOverrides = new Properties();
+
topologyOverrides.put(StreamsConfig.DEFAULT_DESERIALIZATION_EXCEPTION_HANDLER_CLASS_CONFIG,
LogAndFailExceptionHandler.class);
+
topologyOverrides.put(StreamsConfig.DESERIALIZATION_EXCEPTION_HANDLER_CLASS_CONFIG,
LogAndContinueExceptionHandler.class);
+
+ final StreamsConfig config = new
StreamsConfig(StreamsTestUtils.getStreamsConfig());
+ final InternalTopologyBuilder topologyBuilder = new
InternalTopologyBuilder(
+ new TopologyConfig(
+ "my-topology",
+ config,
+ topologyOverrides)
+ );
+
+
assertThat(topologyBuilder.topologyConfigs().getTaskConfig().deserializationExceptionHandler.getClass(),
equalTo(LogAndContinueExceptionHandler.class));
+ }
+
+ @Test
+ public void
exceptionHandlerShouldAcceptNewConfigNoOtherDeprecatedConfigPresent() {
Review Comment:
Updated existing
shouldNotOverrideGlobalStreamsConfigWhenGivenUnnamedTopologyProps
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
