chia7712 commented on code in PR #16992:
URL: https://github.com/apache/kafka/pull/16992#discussion_r1730323750
##########
tools/src/main/java/org/apache/kafka/tools/GetOffsetShell.java:
##########
@@ -107,12 +107,7 @@ private static class GetOffsetShellOptions extends
CommandDefaultOptions {
public GetOffsetShellOptions(String[] args) throws TerseException {
super(args);
- OptionSpec<String> brokerListOpt = parser.accepts("broker-list",
"DEPRECATED, use --bootstrap-server instead; ignored if --bootstrap-server is
specified. The server(s) to connect to in the form HOST1:PORT1,HOST2:PORT2.")
- .withRequiredArg()
- .describedAs("HOST1:PORT1,...,HOST3:PORT3")
- .ofType(String.class);
OptionSpec<String> bootstrapServerOpt =
parser.accepts("bootstrap-server", "REQUIRED. The server(s) to connect to in
the form HOST1:PORT1,HOST2:PORT2.")
Review Comment:
Please rename `effectiveBrokerListOpt` to `bootstrapServerOpt`. Also, please
initialize it in line#110
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
