[
https://issues.apache.org/jira/browse/KAFKA-16567?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17876480#comment-17876480
]
Balaji Rao commented on KAFKA-16567:
------------------------------------
[~cadonna] it seems the remaining metrics
*
{quote}restore-total
{quote}
*
{quote}restore-rate
{quote}
*
{quote}update-total
{quote}
*
{quote}update-rate
{quote}
*
{quote}restore-remaining-records-total
{quote}
are implemented in this
[PR.|https://github.com/apache/kafka/pull/13300/files#diff-4df67afac7b840ed6080d7fae931148c2f661af25eaafd83e0f8535ac34a0b71]
I was planning to try implementing these metrics. I first checked out
DefaultStateUpdater because one of the metrics (restore-call-rate) in the KIP
was defined there. While figuring out how to add the task ID to the new
metrics, I found this PR.
Initially, I thought the metrics from the PR wouldn't work for state updater
since they are recorded from StoreChangelogReader (which I had presumed was the
predecessor to the state updater). But it seems like this shouldn't be an issue
because the state updater uses StoreChangelogReader for the actual restoration
? Just want to make sure!
cc: [~lucasbru], who has kindly offered me to help me with this as my first
contribution to kafka-streams.
> Add New Stream Metrics based on KIP-869
> ---------------------------------------
>
> Key: KAFKA-16567
> URL: https://issues.apache.org/jira/browse/KAFKA-16567
> Project: Kafka
> Issue Type: Task
> Components: streams
> Reporter: Walter Hernandez
> Priority: Major
> Labels: kip
>
> Add the following metrics to the state updater:
> * restore-total
> * restore-rate
> * update-total
> * update-rate
> * restore-remaining-records-total
> Please see the KIP for more information about the metrics.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
