xijiu commented on code in PR #16987:
URL: https://github.com/apache/kafka/pull/16987#discussion_r1729715993


##########
tools/src/main/java/org/apache/kafka/tools/consumer/DefaultMessageFormatter.java:
##########
@@ -130,25 +134,31 @@ public void writeTo(ConsumerRecord<byte[], byte[]> 
consumerRecord, PrintStream o
                 } else {
                     output.print("NO_TIMESTAMP");
                 }
-                writeSeparator(output, printPartition || printOffset || 
printDelivery || printHeaders || printKey || printValue);
+                writeSeparator(output, anyTrue(printPartition, printOffset, 
printDelivery, printEpoch, printHeaders, printKey, printValue));

Review Comment:
   When I coding style like this: `a | b | c | d | e ... `, then I received a 
checkstyle ERROR: 
   ```
   [ant:checkstyle] [ERROR] 
/Users/likangning/xijiu/kafka/tools/src/main/java/org/apache/kafka/tools/consumer/DefaultMessageFormatter.java:137:32:
 Boolean expression complexity is 6 (max allowed is 5). 
[BooleanExpressionComplexity]
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to