m1a2st commented on code in PR #16957:
URL: https://github.com/apache/kafka/pull/16957#discussion_r1728916881
##########
core/src/test/java/kafka/test/annotation/ClusterTest.java:
##########
@@ -34,6 +35,7 @@
@Target({METHOD})
@Retention(RUNTIME)
@TestTemplate
+@Timeout(30)
Review Comment:
> Is it possible for `@ClusterTests` to override this annotation for longer
timeout?
I don't consider I can achieve this using the `@Timeout` annotation alone.
Developers should avoid scenarios where they need to modify this setting. If a
test genuinely requires more than 30 seconds, the `@Timeout`annotation can be
applied at the method level, it will override this annotation.
```java
@Timeout(1)
@ClusterTests({
@ClusterTest(types = {Type.ZK}),
@ClusterTest(types = {Type.KRAFT}, serverProperties = {
@ClusterConfigProperty(key =
AUTHORIZER_CLASS_NAME_CONFIG, value = STANDARD_AUTHORIZER)
})
})
public void testAclCliWithAdminAPI(ClusterInstance cluster) throws
InterruptedException {
Thread.sleep(2000);
testAclCli(cluster, adminArgs(cluster.bootstrapServers(),
Optional.empty()));
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
