kirktrue commented on code in PR #16951:
URL: https://github.com/apache/kafka/pull/16951#discussion_r1728056278
##########
tools/src/main/java/org/apache/kafka/tools/VerifiableConsumer.java:
##########
@@ -529,6 +530,24 @@ private static ArgumentParser argParser() {
.metavar("TOPIC")
.help("Consumes messages from this topic.");
+ parser.addArgument("--group-protocol")
+ .action(store())
+ .required(false)
+ .type(String.class)
+ .setDefault(ConsumerConfig.DEFAULT_GROUP_PROTOCOL)
Review Comment:
AIUI, `VerifiableConsumer` is only used for the system tests, not end users.
A given system test provides the values/arguments to `VerifiableConsumer` as
part of its test. Many tests that use the consumer have been retrofitted to
test both consumer types. However, if a test doesn't explicitly provide a value
for the group protocol, it is delegating to the `ConsumerConfig` to use
whatever defaults it chooses.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
