mjsax commented on code in PR #16803:
URL: https://github.com/apache/kafka/pull/16803#discussion_r1727662431
##########
streams/src/main/java/org/apache/kafka/streams/kstream/internals/KStreamImpl.java:
##########
@@ -450,22 +450,6 @@ public KStream<K, V> peek(final ForeachAction<? super K, ?
super V> action,
builder);
}
- @Deprecated
- @Override
- @SuppressWarnings("unchecked")
- public KStream<K, V>[] branch(final Predicate<? super K, ? super V>...
predicates) {
- return doBranch(NamedInternal.empty(), predicates);
- }
-
- @Deprecated
- @Override
- @SuppressWarnings("unchecked")
- public KStream<K, V>[] branch(final Named named,
- final Predicate<? super K, ? super V>...
predicates) {
- Objects.requireNonNull(named, "named can't be null");
- return doBranch(new NamedInternal(named), predicates);
- }
-
@SuppressWarnings({"unchecked", "rawtypes"})
private KStream<K, V>[] doBranch(final NamedInternal named,
Review Comment:
@frankvicky -- this method in unused now -- can you do a follow up PR to
remove it (using the same Jira).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]