smjn commented on code in PR #16921: URL: https://github.com/apache/kafka/pull/16921#discussion_r1727572775
########## server-common/src/main/java/org/apache/kafka/server/group/share/SharePartitionKey.java: ########## @@ -0,0 +1,77 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.kafka.server.group.share; + +import org.apache.kafka.common.TopicIdPartition; +import org.apache.kafka.common.Uuid; + +import java.util.Objects; + +/** + * Common immutable share partition key class. This class is + * placed in server-common so that it can be freely used across + * various modules. + */ +public class SharePartitionKey { + private final String groupId; + private final Uuid topicId; + private final int partition; Review Comment: > we need accessors for these values. Will add - but they are not utilized anywhere > I think a TopicIdPartition topicIdPartition() accessor would be useful too. Can't do that. I cannot construct a TopicIdPartition object to return since we do not know the topic name and that is necessary to create TopicIdPartition. ########## server-common/src/main/java/org/apache/kafka/server/group/share/SharePartitionKey.java: ########## @@ -0,0 +1,77 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.kafka.server.group.share; + +import org.apache.kafka.common.TopicIdPartition; +import org.apache.kafka.common.Uuid; + +import java.util.Objects; + +/** + * Common immutable share partition key class. This class is + * placed in server-common so that it can be freely used across + * various modules. + */ +public class SharePartitionKey { + private final String groupId; + private final Uuid topicId; + private final int partition; Review Comment: > we need accessors for these values. Will add - but they are not utilized anywhere > I think a TopicIdPartition topicIdPartition() accessor would be useful too. Can't do that. I cannot construct a TopicIdPartition object to return since we do not know the topic name and that is necessary to create TopicIdPartition. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
