smjn commented on code in PR #16921: URL: https://github.com/apache/kafka/pull/16921#discussion_r1726384651
########## share-coordinator/src/main/java/org/apache/kafka/coordinator/share/ShareCoordinator.java: ########## @@ -0,0 +1,94 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.kafka.coordinator.share; + +import org.apache.kafka.common.message.ReadShareGroupStateRequestData; +import org.apache.kafka.common.message.ReadShareGroupStateResponseData; +import org.apache.kafka.common.message.WriteShareGroupStateRequestData; +import org.apache.kafka.common.message.WriteShareGroupStateResponseData; +import org.apache.kafka.common.requests.RequestContext; + +import java.util.OptionalInt; +import java.util.Properties; +import java.util.concurrent.CompletableFuture; +import java.util.function.IntSupplier; + +public interface ShareCoordinator { + short SHARE_SNAPSHOT_RECORD_KEY_VERSION = 0; + short SHARE_SNAPSHOT_RECORD_VALUE_VERSION = 0; + short SHARE_UPDATE_RECORD_KEY_VERSION = 1; + short SHARE_UPDATE_RECORD_VALUE_VERSION = 1; + + /** + * Return the partition index for the given key. + * + * @param key key - groupId:topicId:partitionId. + * @return The partition index. + */ + int partitionFor(String key); + + /** + * Return the configuration properties of the share-group state topic. + * + * @return Properties of the share-group state topic. + */ + Properties shareGroupStateTopicConfigs(); + + /** + * Start the share coordinator + * + * @param shareGroupTopicPartitionCount - supplier returning the number of partitions for __share_group_state topic + */ + void startup(IntSupplier shareGroupTopicPartitionCount); + + /** + * Stop the share coordinator + */ + void shutdown(); + + /** + * Handle write share state call + * @param context - represents the incoming write request context Review Comment: Following. All occurrences in PR ``` * @param key - groupId:topicId:partitionId. * @param shareGroupTopicPartitionCount - supplier returning the number of partitions for __share_group_state topic * @param context - represents the incoming write request context * @param request - actual RPC request object * @param context - represents the incoming read request context * @param request - actual RPC request object * @param partitionIndex - The partition index (internal topic) * @param partitionLeaderEpoch - Leader epoch of the partition (internal topic) * @param partitionIndex - The partition index (internal topic) * @param partitionLeaderEpoch - Leader epoch of the partition (internal topic). Empty optional means deleted. * @param recordType - short representing version * @param recordType - short representing version ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
