dajac commented on code in PR #16945:
URL: https://github.com/apache/kafka/pull/16945#discussion_r1726565209
##########
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupCoordinator.java:
##########
@@ -63,6 +63,11 @@
*/
public interface GroupCoordinator {
+ /**
+ * @return True if the new coordinator; False otherwise.
+ */
+ boolean isNewGroupCoordinator();
Review Comment:
I introduced this new method to the GroupCoordinator interface and I use it
at runtime (e.g. in KafkaApi) to determine whether the new or the old
coordinator is used. I did not in order to not rely on the
`group.coordinator.new.enable` configuration at runtime. The issue was that in
ZK mode, the `group.coordinator.new.enable` is also true by default now but the
configuration is just ignored when the zk broker starts.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
