OmniaGM commented on code in PR #16920:
URL: https://github.com/apache/kafka/pull/16920#discussion_r1724879717
##########
core/src/test/scala/integration/kafka/api/PlaintextAdminIntegrationTest.scala:
##########
@@ -1948,6 +1948,166 @@ class PlaintextAdminIntegrationTest extends
BaseAdminIntegrationTest {
}
}
+ @ParameterizedTest
+ @ValueSource(strings = Array("kraft+kip932"))
+ def testShareGroups(quorum: String): Unit = {
+ val config = createConfig
+ client = Admin.create(config)
+ try {
+ // Verify that initially there are no share groups to list.
+ val list1 = client.listShareGroups()
+ assertTrue(0 == list1.all().get().size())
+ assertTrue(0 == list1.errors().get().size())
+ assertTrue(0 == list1.valid().get().size())
+ val testTopicName = "test_topic"
+ val testNumPartitions = 2
+
+ client.createTopics(util.Arrays.asList(
+ new NewTopic(testTopicName, testNumPartitions, 1.toShort)
+ )).all().get()
+ waitForTopics(client, List(testTopicName), List())
+
+ val producer = createProducer()
Review Comment:
Can't we create Producer out side of the `try` like admin and move
`Utils.closeQuietly(producer, "producer")` to `finally` block this will reduce
the amount of `try` blocks in this code?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
