m1a2st commented on code in PR #16893:
URL: https://github.com/apache/kafka/pull/16893#discussion_r1723769119
##########
core/src/main/scala/kafka/server/KafkaApis.scala:
##########
@@ -2529,8 +2529,8 @@ class KafkaApis(val requestChannel: RequestChannel,
}
def ensureInterBrokerVersion(version: MetadataVersion): Unit = {
- if (config.interBrokerProtocolVersion.isLessThan(version))
- throw new UnsupportedVersionException(s"inter.broker.protocol.version:
${config.interBrokerProtocolVersion} is less than the required version:
${version}")
+ if (metadataCache.metadataVersion().isLessThan(version))
+ throw new UnsupportedVersionException(s"inter.broker.protocol.version:
${metadataCache.metadataVersion()} is less than the required version:
${version}")
Review Comment:
Thanks for your comment, I will modify this. Should I use the
`metadata.version` is clear enough?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
