chia7712 commented on PR #16936: URL: https://github.com/apache/kafka/pull/16936#issuecomment-2299163145
> we must take care not to inject secrets into pull_request_target workflows. not sure whether I misunderstand the "inject". IIRC, `secrets` is a safe way recommended by Github (https://docs.github.com/en/actions/security-for-github-actions/security-guides/using-secrets-in-github-actions), and other apache projects are using that to enable some extra services (gradle dvelocity, CodeCov, etc.) in short, I don't think `secrets` will "export" the token but it does "inject" the secrets. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
