chia7712 commented on code in PR #16864:
URL: https://github.com/apache/kafka/pull/16864#discussion_r1723275012
##########
core/src/main/java/kafka/log/remote/quota/RLMQuotaManager.java:
##########
@@ -112,10 +110,7 @@ private Sensor sensor() {
return sensorAccess.getOrCreate(
quotaType.toString(),
RLMQuotaManagerConfig.INACTIVE_SENSOR_EXPIRATION_TIME_SECONDS,
- sensor -> {
- sensor.add(metricName(), new SimpleRate(),
getQuotaMetricConfig(quota));
- return BoxedUnit.UNIT;
- }
+ sensor -> sensor.add(metricName(), new SimpleRate(),
getQuotaMetricConfig(quota))
Review Comment:
`SensorAccess` is used by RLM also, hence it would be better to move
`SensorAccess` to server-common module.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
