FrankYang0529 commented on code in PR #16876:
URL: https://github.com/apache/kafka/pull/16876#discussion_r1722564737
##########
clients/src/main/java/org/apache/kafka/common/requests/ListOffsetsRequest.java:
##########
@@ -58,17 +58,21 @@ public class ListOffsetsRequest extends AbstractRequest {
public static class Builder extends
AbstractRequest.Builder<ListOffsetsRequest> {
private final ListOffsetsRequestData data;
- public static Builder forReplica(short allowedVersion, int replicaId) {
- return new Builder((short) 0, allowedVersion, replicaId,
IsolationLevel.READ_UNCOMMITTED);
+ public static Builder forConsumer(boolean requireTimestamp,
+ IsolationLevel isolationLevel) {
+ return forConsumer(requireTimestamp, isolationLevel, false, false,
false);
}
public static Builder forConsumer(boolean requireTimestamp,
IsolationLevel isolationLevel,
boolean requireMaxTimestamp,
+ boolean requireEarliestTimestamp,
boolean
requireTieredStorageTimestamp) {
short minVersion = 0;
if (requireTieredStorageTimestamp)
minVersion = 9;
+ else if (requireEarliestTimestamp)
Review Comment:
Hi @chia7712 and @frankvicky, What does `requireEarliestTimestamp` mean?
`EARLIEST_TIMESTAMP` or `EARLIEST_LOCAL_TIMESTAMP`? If it's
`EARLIEST_LOCAL_TIMESTAMP`, probably we should change the parameter name as
`requireEarliestLocalTimestamp`, so users don't misunderstand it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
