[
https://issues.apache.org/jira/browse/KAFKA-17360?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17874792#comment-17874792
]
Luke Chen commented on KAFKA-17360:
-----------------------------------
No, even if we set it to
{code:java}
deleteOldSegments(shouldDelete, RetentionSizeBreach(this,
remoteLogEnabledAndRemoteCopyEnabled())){code}
It will still output
{code:java}
Deleting segment 1 due to local log retention size -2 breach. {code}
The point here is, we should not output any "-2" to the user because that's not
meaningful to the users. We should replace it with the server side config value.
> Improve log message when log retention ms/bytes is -2
> -----------------------------------------------------
>
> Key: KAFKA-17360
> URL: https://issues.apache.org/jira/browse/KAFKA-17360
> Project: Kafka
> Issue Type: Improvement
> Reporter: Luke Chen
> Priority: Major
>
> When setting retention.ms/bytes to -2, we can notice this log message:
> {code:java}
> Deleting segment LogSegment(baseOffset=10045, size=1037087,
> lastModifiedTime=1724040653922, largestRecordTimestamp=1724040653835) due to
> local log retention size -2 breach. Local log size after deletion will be
> 13435280. (kafka.log.UnifiedLog) [kafka-scheduler-6]{code}
> This is not helpful for users. We should replace -2 with real retention value
> when logging.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
