chia7712 commented on code in PR #16893:
URL: https://github.com/apache/kafka/pull/16893#discussion_r1720566919
##########
core/src/main/scala/kafka/coordinator/transaction/TransactionMarkerChannelManager.scala:
##########
@@ -261,7 +257,9 @@ class TransactionMarkerChannelManager(
}.filter { case (_, entries) => !entries.isEmpty }.map { case (node,
entries) =>
val markersToSend = entries.asScala.map(_.txnMarkerEntry).asJava
val requestCompletionHandler = new
TransactionMarkerRequestCompletionHandler(node.id, txnStateManager, this,
entries)
- val request = new
WriteTxnMarkersRequest.Builder(writeTxnMarkersRequestVersion, markersToSend)
+ val request = new WriteTxnMarkersRequest.Builder(
+ config.interBrokerProtocolVersion.writeTxnMarkersRequestVersion(),
markersToSend
Review Comment:
`config.interBrokerProtocolVersion` is used in code base. in zk mode,
`metadataCache.metadataVersion` is static config. By contrast, kraft has
dynamic MV. Hence, we should apply that change
(`config.interBrokerProtocolVersion` -> `metadataCache.metadataVersion`) to
code base. BTW, that will be a large PR I guess @junrao @jolshan WDYT?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
