apoorvmittal10 commented on PR #16888: URL: https://github.com/apache/kafka/pull/16888#issuecomment-2292350375
> > @apoorvmittal10 thanks for the patch! Moving out of `:core` makes good sense to me. > > WDYT about putting the new share partition code into a new `:share` module instead of `:server`. The `:server` module is a catch-all module similar to `:core`, so it has a lot of dependencies. This means we'll be recompiling more often than not when pulling in changes. > > Sure, I shall do that. I have added the `share` module, please review. The package I have kept is `org.apache.kafka.server.share`. I was thinking whether to have `org.apache.kafka.share` or `org.apache.kafka.server.share`, the latter makes more sense as it's server code and matches the current package naming. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
