xijiu opened a new pull request, #16875:
URL: https://github.com/apache/kafka/pull/16875

   The ConsumerNetworkThreadTest currently has a number of tests which do the 
following:
   
   1. Add event of type `T` to the event queue
   2. Call ConsumerNetworkThread.runOnce() to dequeue the events and call 
ApplicationEventProcessor.process()
   3. Verify that the appropriate ApplicationEventProcessor process method was 
invoked for the event
   
   Those types of tests should be moved to ApplicationEventProcessorTest.
   
   The methods that satisfies the conditions are
   
   - `testApplicationEventIsProcessed`
   - `testListOffsetsEventIsProcessed`
   - `testResetPositionsProcessFailureIsIgnored`
   
   ### Committer Checklist (excluded from commit message)
   - [ ] Verify design and implementation 
   - [ ] Verify test coverage and CI build status
   - [ ] Verify documentation (including upgrade notes)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to