showuon commented on code in PR #16643:
URL: https://github.com/apache/kafka/pull/16643#discussion_r1715141352
##########
core/src/main/scala/kafka/server/ReplicationQuotaManager.scala:
##########
@@ -97,7 +98,7 @@ class ReplicationQuotaManager(val config:
ReplicationQuotaManagerConfig,
* Is the passed partition throttled by this ReplicationQuotaManager
*
* @param topicPartition the partition to check
- * @return
+ * @return false if the partition doesn't exist otherwise return false
Review Comment:
Could you check the implementation again and update the java doc?
##########
core/src/main/scala/kafka/server/ReplicationQuotaManager.scala:
##########
@@ -141,8 +141,8 @@ class ReplicationQuotaManager(val config:
ReplicationQuotaManagerConfig,
/**
* Remove list of throttled replicas for a certain topic
*
- * @param topic
- * @return
+ * @param topic the target topic to remove.
+ * @return the previous partitions associated with key, or null if there
was no mapping for key.
Review Comment:
hmm... This is not right.
##########
core/src/main/scala/kafka/server/ReplicationQuotaManager.scala:
##########
@@ -79,7 +79,8 @@ class ReplicationQuotaManager(val config:
ReplicationQuotaManagerConfig,
/**
* Check if the quota is currently exceeded
*
- * @return
+ * @return false : if the quota is currently exceeded.
+ * true : if we violated our quota for any metric that has a
configured quota
Review Comment:
Is this correct?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
