[
https://issues.apache.org/jira/browse/KAFKA-17312?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17872688#comment-17872688
]
Chia-Ping Tsai commented on KAFKA-17312:
----------------------------------------
[~yangpoan] thanks for this report. It seems to me those removed methods should
be added into `ignoreMethods`, as we expect they are NOT exposed now. WDYT?
> Fix tests shouldForwardAllDbOptionsCalls and shouldOverwriteAllOptionsMethods
> in RocksDBGenericOptionsToDbOptionsColumnFamilyOptionsAdapterTest
> -----------------------------------------------------------------------------------------------------------------------------------------------
>
> Key: KAFKA-17312
> URL: https://issues.apache.org/jira/browse/KAFKA-17312
> Project: Kafka
> Issue Type: Sub-task
> Reporter: PoAn Yang
> Assignee: PoAn Yang
> Priority: Major
>
> CI:
> [https://ci-builds.apache.org/job/Kafka/job/kafka/job/trunk/3189/cloudbees-pipeline-explorer/]
>
> RocksDBGenericOptionsToDbOptionsColumnFamilyOptionsAdapterTest#shouldForwardAllDbOptionsCalls
> {code:java}
> org.opentest4j.AssertionFailedError: Should have called
> DBOptions.maxBackgroundCompactions() ==> expected: <true> but was: <false>
> at
> org.junit.jupiter.api.AssertionFailureBuilder.build(AssertionFailureBuilder.java:151)
> at
> org.junit.jupiter.api.AssertionFailureBuilder.buildAndThrow(AssertionFailureBuilder.java:132)
> at org.junit.jupiter.api.AssertTrue.failNotTrue(AssertTrue.java:63)
> at org.junit.jupiter.api.AssertTrue.assertTrue(AssertTrue.java:36)
> at org.junit.jupiter.api.Assertions.assertTrue(Assertions.java:214)
> at
> org.apache.kafka.streams.state.internals.RocksDBGenericOptionsToDbOptionsColumnFamilyOptionsAdapterTest.verifyDBOptionsMethodCall(RocksDBGenericOptionsToDbOptionsColumnFamilyOptionsAdapterTest.java:148)
> at
> org.apache.kafka.streams.state.internals.RocksDBGenericOptionsToDbOptionsColumnFamilyOptionsAdapterTest.shouldForwardAllDbOptionsCalls(RocksDBGenericOptionsToDbOptionsColumnFamilyOptionsAdapterTest.java:131)
> at java.lang.reflect.Method.invoke(Method.java:498)
> at java.util.ArrayList.forEach(ArrayList.java:1259)
> at java.util.ArrayList.forEach(ArrayList.java:1259) {code}
> RocksDBGenericOptionsToDbOptionsColumnFamilyOptionsAdapterTest#shouldOverwriteAllOptionsMethods
> {code:java}
> java.lang.NoSuchMethodException:
> org.apache.kafka.streams.state.internals.RocksDBGenericOptionsToDbOptionsColumnFamilyOptionsAdapter.maxBackgroundCompactions()
> at java.lang.Class.getDeclaredMethod(Class.java:2130)
> at
> org.apache.kafka.streams.state.internals.RocksDBGenericOptionsToDbOptionsColumnFamilyOptionsAdapterTest.shouldOverwriteAllOptionsMethods(RocksDBGenericOptionsToDbOptionsColumnFamilyOptionsAdapterTest.java:120)
> at java.lang.reflect.Method.invoke(Method.java:498)
> at java.util.ArrayList.forEach(ArrayList.java:1259)
> at java.util.ArrayList.forEach(ArrayList.java:1259) {code}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
