frankvicky commented on code in PR #16833:
URL: https://github.com/apache/kafka/pull/16833#discussion_r1711637051
##########
clients/src/test/java/org/apache/kafka/clients/consumer/internals/CommitRequestManagerTest.java:
##########
@@ -688,7 +688,8 @@ public void testOffsetFetchRequestTimeoutRequests(final
Errors error) {
}
private boolean isRetriableOnOffsetFetch(Errors error) {
- return error == Errors.NOT_COORDINATOR || error ==
Errors.COORDINATOR_LOAD_IN_PROGRESS || error ==
Errors.COORDINATOR_NOT_AVAILABLE;
+ return error == Errors.NOT_COORDINATOR || error ==
Errors.COORDINATOR_LOAD_IN_PROGRESS || error == Errors.COORDINATOR_NOT_AVAILABLE
+ || error == Errors.UNKNOWN_TOPIC_OR_PARTITION || error ==
Errors.REQUEST_TIMED_OUT || error == Errors.UNSTABLE_OFFSET_COMMIT;
Review Comment:
Hi @lianetm,
Thanks for pointing that out. You are right, in this case, we should use
`instanceof RetriableException` instead of the helper method, as we already
consider all retriable exceptions should be retried. I will remove the method
and replace its usage with the instanceof expression.
Thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
