jsancio commented on code in PR #16774:
URL: https://github.com/apache/kafka/pull/16774#discussion_r1708147558
##########
core/src/main/scala/kafka/tools/StorageTool.scala:
##########
@@ -190,8 +193,8 @@ object StorageTool extends Logging {
help("Used to initialize a single-node quorum controller quorum.").
action(storeTrue())
reconfigurableQuorumOptions.addArgument("--initial-controllers", "-I").
- help("A list of controller quorum voter ids, directories, and
hostname:port pairs. The same values must be used to format all nodes. For
example:\n" +
-
"0@localhost:8082:JEXY6aqzQY-32P5TStzaFg@,1@localhost:8083:MvDxzVmcRsaTz33bUuRU6A,2@localhost:8084:07R5amHmR32VDA6jHkGbTA\n").
+ help("The initial controllers, as a comma-separated list of
id@hostname:port:directory. The same values must be used to format all nodes.
For example:\n" +
+
"[email protected]:8082:JEXY6aqzQY-32P5TStzaFg,[email protected]:8083:MvDxzVmcRsaTz33bUuRU6A,[email protected]:8084:07R5amHmR32VDA6jHkGbTA\n").
Review Comment:
Good point. We need to mentioned somewhere that IPv6 need to be escaped with
the `[]` characters.
##########
raft/src/main/java/org/apache/kafka/raft/RaftUtil.java:
##########
@@ -67,6 +68,8 @@ public static ApiMessage errorResponse(ApiKeys apiKey, Errors
error) {
return new FetchResponseData().setErrorCode(error.code());
case FETCH_SNAPSHOT:
return new
FetchSnapshotResponseData().setErrorCode(error.code());
+ case API_VERSIONS:
+ return new
ApiVersionsResponseData().setErrorCode(error.code());
Review Comment:
I need to add UpdateVoter to this switch too. Let me do that in my PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
