brandboat commented on code in PR #16789:
URL: https://github.com/apache/kafka/pull/16789#discussion_r1704119775
##########
tools/src/main/java/org/apache/kafka/tools/PushHttpMetricsReporter.java:
##########
@@ -96,7 +97,31 @@ public class PushHttpMetricsReporter implements
MetricsReporter {
"producer/consumer/streams/connect instance");
public PushHttpMetricsReporter() {
- time = Time.SYSTEM;
+ // This is for backward compatibility with older versions like 0.8 and
0.9,
Review Comment:
> another fix is that we can change time from Time to Supplier<Long> to
offer current time. WDYT?
Thanks for the review, this one looks better.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
