kamalcph commented on code in PR #16765:
URL: https://github.com/apache/kafka/pull/16765#discussion_r1702757466
##########
core/src/test/scala/unit/kafka/log/LogTestUtils.scala:
##########
@@ -68,7 +69,9 @@ object LogTestUtils {
indexIntervalBytes: Int =
ServerLogConfigs.LOG_INDEX_INTERVAL_BYTES_DEFAULT,
segmentIndexBytes: Int =
ServerLogConfigs.LOG_INDEX_SIZE_MAX_BYTES_DEFAULT,
fileDeleteDelayMs: Long =
ServerLogConfigs.LOG_DELETE_DELAY_MS_DEFAULT,
- remoteLogStorageEnable: Boolean =
LogConfig.DEFAULT_REMOTE_STORAGE_ENABLE): LogConfig = {
+ remoteLogStorageEnable: Boolean =
LogConfig.DEFAULT_REMOTE_STORAGE_ENABLE,
+ remoteCopyDisabled: Boolean =
DEFAULT_REMOTE_LOG_COPY_DISABLED_CONFIG,
Review Comment:
nit:
rename `remoteCopyDisabled` to `remoteLogCopyDisable`
##########
storage/src/main/java/org/apache/kafka/storage/internals/log/LogConfig.java:
##########
@@ -186,6 +186,8 @@ public Optional<String> serverConfigName(String configName)
{
public static final long DEFAULT_MESSAGE_TIMESTAMP_DIFFERENCE_MAX_MS =
ServerLogConfigs.LOG_MESSAGE_TIMESTAMP_DIFFERENCE_MAX_MS_DEFAULT;
public static final boolean DEFAULT_REMOTE_STORAGE_ENABLE = false;
+ public static final boolean DEFAULT_REMOTE_LOG_COPY_DISABLED_CONFIG =
false;
Review Comment:
nit:
rename `DEFAULT_REMOTE_LOG_COPY_DISABLED_CONFIG` to
`DEFAULT_REMOTE_LOG_COPY_DISABLE_CONFIG`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
