FrankYang0529 commented on code in PR #16781:
URL: https://github.com/apache/kafka/pull/16781#discussion_r1702437066
##########
core/src/test/scala/unit/kafka/server/ListOffsetsRequestTest.scala:
##########
@@ -92,19 +93,30 @@ class ListOffsetsRequestTest extends BaseRequestTest {
assertResponseError(Errors.NOT_LEADER_OR_FOLLOWER, nonReplica,
debugReplicaRequest)
}
- @ParameterizedTest
- @ValueSource(strings = Array("zk", "kraft"))
- def testListOffsetsMaxTimeStampOldestVersion(quorum: String): Unit = {
+ @Test
+ def testListOffsetsMaxTimeStampOldestVersion(): Unit = {
Review Comment:
I add it back, but I think this test is unit test, so we don't need to test
it on both zk and kraft modes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
