muralibasani commented on PR #16762: URL: https://github.com/apache/kafka/pull/16762#issuecomment-2264956704
> > Any reason why you did a single PR for two tickets? It's cleaner if a PR does not fix multiple tickets (also easier to review if PRs are smaller). > > @mjsax I interpreted it differently when you mentioned that both tickets should be worked together in the description of ticket. Indeed it's cleaner with smaller PRs. Will split this one today. > > Any reason why you did a single PR for two tickets? It's cleaner if a PR does not fix multiple tickets (also easier to review if PRs are smaller). > > @mjsax I interpreted it differently when you mentioned that both tickets should be worked together in the description of ticket. Indeed it's cleaner with smaller PRs. Will split this one today. @mjsax just realized I haven't made any changes related to 16330 in this PR. So we are all good. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
