kamalcph commented on code in PR #16653:
URL: https://github.com/apache/kafka/pull/16653#discussion_r1701198045
##########
storage/src/main/java/org/apache/kafka/storage/internals/log/LogConfig.java:
##########
@@ -515,8 +515,8 @@ public Boolean remoteLogDeleteOnDisable() {
return remoteLogConfig.remoteLogDeleteOnDisable;
}
- public Boolean remoteCopyDisabled() {
- return remoteLogConfig.remoteCopyDisabled;
+ public Boolean remoteLogCopyDisable() {
Review Comment:
My suggestion was to change the name of the topic config.
This method name sounds like a setter. can we rename it to
`isRemoteLogCopyDisabled` here and other places?
(eg) https://github.com/apache/kafka/pull/16256
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
