ardada2468 commented on code in PR #16761:
URL: https://github.com/apache/kafka/pull/16761#discussion_r1701082806
##########
tools/src/main/java/org/apache/kafka/tools/StreamsResetter.java:
##########
@@ -93,7 +93,7 @@ public class StreamsResetter {
private static final String USAGE = "This tool helps to quickly reset an
application in order to reprocess "
+ "its data from scratch.\n"
+ "* This tool resets offsets of input topics to the earliest
available offset (by default), or to a specific defined position"
- + " and it skips to the end of intermediate topics (topics that
are input and output topics, e.g., used by deprecated through() method).\n"
+ + " and it skips to the end of intermediate topics (topics that
are input and output topics.\n"
Review Comment:
Good Catch, I have just patched that in the latest commit.
##########
streams/src/test/java/org/apache/kafka/streams/kstream/internals/KStreamImplTest.java:
##########
@@ -1285,62 +1257,6 @@ public void
shouldNotAllowNullValueJoinerWithKeyOnLeftJoinWithGlobalTableWithNam
assertThat(exception.getMessage(), equalTo("joiner can't be null"));
}
- @SuppressWarnings({"unchecked", "deprecation"}) // specifically testing
the deprecated variant
- @Test
- public void testNumProcesses() {
Review Comment:
Okay, I have also patched this in the latest commit
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
