mjsax commented on code in PR #16432:
URL: https://github.com/apache/kafka/pull/16432#discussion_r1697934599
##########
streams/src/main/java/org/apache/kafka/streams/processor/internals/RecordDeserializer.java:
##########
@@ -80,12 +81,29 @@ public static void handleDeserializationFailure(final
DeserializationExceptionHa
final
ConsumerRecord<byte[], byte[]> rawRecord,
final Logger log,
final Sensor
droppedRecordsSensor) {
+ handleDeserializationFailure(deserializationExceptionHandler,
processorContext, deserializationException, rawRecord, log,
droppedRecordsSensor, null);
Review Comment:
Well, the "helper" method also only calls the second one, setting
`sourceNodeName` to `null`. Why can't we just call the second one from
`GlobalStateManagerImpl` directly also setting it to `null`, and thus avoiding
the need for the overload? The overload does not really add much value, or does
it?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
