mjsax commented on code in PR #16300:
URL: https://github.com/apache/kafka/pull/16300#discussion_r1696286131
##########
streams/src/main/java/org/apache/kafka/streams/processor/internals/StreamTask.java:
##########
@@ -916,7 +920,17 @@ public void punctuate(final ProcessorNode<?, ?, ?, ?> node,
} catch (final StreamsException e) {
Review Comment:
Ignore me comment above -- I was looking at an outdate `trunk`... my bad.
Seem the code is already doing the correct thing now.
But this PR still needs an update, to follow the same patterns in
`punctuate()` as we have for `process()`.
> Considering TaskCorruptedException/TaskMigratedException cannot reach
punctuate(), we updated the PR to handle all StreamsException in the punctuate.
As you sure about this? In the end, `punctuate()` can call
`context.forward()` and can also reach `RecordCollectorImpl#send()` which might
throw these exception?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
