lianetm commented on code in PR #16691:
URL: https://github.com/apache/kafka/pull/16691#discussion_r1693065009
##########
clients/src/test/java/org/apache/kafka/clients/consumer/internals/ShareHeartbeatRequestManagerTest.java:
##########
@@ -80,11 +76,11 @@
import static org.mockito.Mockito.when;
public class ShareHeartbeatRequestManagerTest {
- private final long retryBackoffMs = DEFAULT_RETRY_BACKOFF_MS;
- private final int heartbeatIntervalMs = DEFAULT_HEARTBEAT_INTERVAL_MS;
- private final int maxPollIntervalMs = DEFAULT_MAX_POLL_INTERVAL_MS;
- private final long retryBackoffMaxMs = DEFAULT_RETRY_BACKOFF_MAX_MS;
- private static final String DEFAULT_GROUP_ID = "groupId";
+ private static final int DEFAULT_HEARTBEAT_INTERVAL_MS = 1000;
+ private static final int DEFAULT_MAX_POLL_INTERVAL_MS = 10000;
+ private static final long DEFAULT_RETRY_BACKOFF_MAX_MS = 1000;
+ private static final long DEFAULT_RETRY_BACKOFF_MS = 80;
+ private static final String DEFAULT_GROUP_ID = "group-id";
Review Comment:
For the share groups case, there is a `ShareConsumerTestBuilder` that
already contains all these. I think we should use it here
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
