mjsax commented on code in PR #16093:
URL: https://github.com/apache/kafka/pull/16093#discussion_r1692228000
##########
streams/src/main/java/org/apache/kafka/streams/TopologyConfig.java:
##########
@@ -151,6 +154,7 @@ public TopologyConfig(final String topologyName, final
StreamsConfig globalAppCo
this.applicationConfigs = globalAppConfigs;
this.topologyOverrides = topologyOverrides;
+ this.processingExceptionHandlerSupplier = () ->
globalAppConfigs.getConfiguredInstance(PROCESSING_EXCEPTION_HANDLER_CLASS_CONFIG,
ProcessingExceptionHandler.class);
Review Comment:
Sure, but line 288 could just be
```
globalAppConfigs.getConfiguredInstance(PROCESSING_EXCEPTION_HANDLER_CLASS_CONFIG,
ProcessingExceptionHandler.class
```
Not sure why we _need_ the supplier indirection?
For the existing `timestampExtractorSupplier` and
`deserializationExceptionHandlerSupplier` is a little different because we
setup different suppliers for different cases (so using suppliers simplifies
the code), but for the new one we have only one supplier and thus it seem
unnecessary.
No need to change anything. We follow an established pattern, but it just
was confusing to me, as it seems (strictly speaking) unnecessary to have the
layer of indirection.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
