[
https://issues.apache.org/jira/browse/KAFKA-17164?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17868547#comment-17868547
]
dujian0068 commented on KAFKA-17164:
------------------------------------
Hello：
I agree that the verification process should be placed in StreamsConfig, and it
is necessary. Distributed validation is not conducive to our modification and
maintenance.
We don't seem to have to worry about `new StreamsConfig(...)` causing an
exception, because if the value format set by the user is incorrect, an
exception will also occur when using this value
If this problem needs to be fixed I'd be happy to fix it
Thank you
> Consider to enforce application.server <server>:<port> format at config level
> -----------------------------------------------------------------------------
>
> Key: KAFKA-17164
> URL: https://issues.apache.org/jira/browse/KAFKA-17164
> Project: Kafka
> Issue Type: Improvement
> Components: streams
> Reporter: Matthias J. Sax
> Priority: Minor
> Labels: needs-kip
>
> KafkaStreams support configuration parameter `application.server` which must
> be of format `<server>:<port>`.
> However, in `StreamsConfig` we accept any `String` w/o validation, but only
> validate the format inside `KafkaStreams` constructor.
> It might be better to add an `AbstactConfig.Validator` and move this
> validation into `StreamsConfig` directly.
> This would be a semantic change because `new StreamsConfig(...)` might now
> throw an exception. Thus we need a KIP for this change, and it's technically
> backward incompatible... (So not sure if we can do this at all – expect for a
> major release? – But 4.0 is close...)
> The ROI is unclear to be fair. Filing this ticket mainly for documentation
> and to collect feedback if people think it would be a worthwhile thing to do
> or not.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
