chia7712 commented on code in PR #16599:
URL: https://github.com/apache/kafka/pull/16599#discussion_r1690292626
##########
connect/runtime/src/test/java/org/apache/kafka/connect/util/clusters/EmbeddedKafkaCluster.java:
##########
@@ -447,9 +326,9 @@ public void createTopic(String topic, int partitions, int
replication, Map<Strin
* @param adminClientConfig Additional admin client configuration settings.
*/
public void createTopic(String topic, int partitions, int replication,
Map<String, String> topicConfig, Map<String, Object> adminClientConfig) {
- if (replication > brokers.length) {
+ if (replication > cluster.brokers().size()) {
Review Comment:
> unless it would leave to a regression I'd prefer not to block this PR on
figuring that out and save it for a follow-up. Is that alright?
make senses to me :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
